docs: update integrations-guide/
#10608
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Thank you for jumping on the issue @jsparkdev ! Just a question from me!
| @@ -83,16 +83,30 @@ Most package managers will install associated peer dependencies as well. If you | |||
|
|
|||
| Then, apply the integration to your `astro.config.*` file using the `integrations` property: | |||
|
|
|||
| ```js title="astro.config.mjs" ins={2} ins="solid()" | |||
| ```js title="astro.config.mjs" ins={2} ins="solidJs()" | |||
There was a problem hiding this comment.
Just confirming for myself that astro add solid does add the solid integration named this way, so seems like a change consistent with the CLI tool!
There was a problem hiding this comment.
Yes, that's correct. I'm trying to respect the installation method through CLI as much as possible.
| @@ -66,17 +66,17 @@ Most package managers will install associated peer dependencies as well. If you | |||
| <PackageManagerTabs> | |||
| <Fragment slot="npm"> | |||
| ```sh | |||
| npm install svelte | |||
| npm install svelte typescript | |||
There was a problem hiding this comment.
Should the sentence above also match something like what you added for React? "you'll need to install Svelte with typescript" if you're making this change?
There was a problem hiding this comment.
Good point, thanks to you I also fixed the wrong inline code highlighting :)
Description (required)
integrations-guide/