[migration guide] Moving to MDX does NOT require changing layout #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
LGTM! We should of course wait until the feature has actually been released. :) |
delucis
approved these changes
Jul 30, 2022
There was a problem hiding this comment.
Merging as the layout feature went out last night in @astrojs/mdx v0.4.0.
The given code example did not use the default export correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relies on withastro/astro#4088
Since @bholmesdev gave us
layout:in MDX, we no longer have to tell people to use a Layout component when converting their.mdfiles to.mdxThis removes that step, and updates the MDX code sample to show no
<Layout>component being used, in favour oflayout:in the frontmatter (which should be what they had before).NOTE: While there is more exciting MDX layout stuff possible now, for the purposes of just explicitly explaining how to convert an existing Astro
.mdfile to a working.mdxfile, we don't need to mention that.