Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for withastro/astro#4947 #1655

Merged
merged 7 commits into from
Oct 13, 2022
Merged

Added documentation for withastro/astro#4947 #1655

merged 7 commits into from
Oct 13, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Oct 1, 2022

What kind of changes does this PR include?

  • New or updated content

Description

Adds documentation for withastro/astro#4947

@netlify
Copy link

netlify bot commented Oct 1, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit dfe7ea6
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6348486b3460bd0008d49565
😎 Deploy Preview https://deploy-preview-1655--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JuanM04 JuanM04 mentioned this pull request Oct 1, 2022
Merged
delucis
delucis reviewed Oct 1, 2022
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JuanM04! Looks good. I’m going to mark this PR as a draft until https://github.com/withastro/astro#4947 is merged, to make sure we don’t merge it ahead of time 🙌

src/pages/en/reference/integrations-reference.md Outdated Show resolved Hide resolved
@delucis delucis marked this pull request as draft October 1, 2022 14:25
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Oct 2, 2022
@sarah11918
Copy link
Member

Thanks, @JuanM04, looks great! 🥳

@delucis - Procedural question: how do we know when/whether this is to be labeled as a draft vs merge-on-release? 😅

@delucis
Copy link
Member

delucis commented Oct 5, 2022

Procedural question: how do we know when/whether this is to be labeled as a draft vs merge-on-release?

I guess draft until withastro/astro#4947 is accepted and then merge-on-release if the upstream PR won’t be merged until a minor release?

@sarah11918 sarah11918 marked this pull request as ready for review October 12, 2022 21:23
@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Oct 12, 2022
@sarah11918 sarah11918 added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 13, 2022
@sarah11918 sarah11918 merged commit 3fae7b0 into main Oct 13, 2022
@sarah11918 sarah11918 deleted the feat/watch-target-4947 branch October 13, 2022 17:25
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

@sarah11918 sarah11918 sarah11918 left review comments

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanM04 @sarah11918 @delucis