Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data collections and collection references #3233
Data collections and collection references #3233
Changes from 34 commits
a887012
e46f44f
85a8063
2ba25b9
e512c1e
4874ff8
6c7ab0e
3faf595
a41f6d3
34f95ef
82fbbde
ae796ba
07e7bea
366c6dc
72babfd
a983414
29bfc00
cbdeddf
f616d9d
65a9de0
929e9c2
4eb0a49
44206dd
d66e204
26ffb38
41af67e
f68b439
ad552e1
f7b1c72
b20e774
dcfbaf6
94fc260
8d63281
75861a0
6654060
f73cd1f
a7e0259
ba88b9a
2e5973a
9ad26bf
5cff403
6e1eb7e
cf1ba03
c2d3a49
e91a5d3
2a063a1
5420f79
a9dd9be
0cac3a6
b6f0e48
fc64768
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had an issue with someone over the underscore thing this morning, so I think this is a good place to qualify "you can use any filename you want"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I agree documenting the underscore pattern is useful, but this isn't quite right. Underscore files will still be included in the build if you're using them for, say, relative image paths or MDX component imports. They're just excluded from collection queries. Wondering if this is the best place to explain that given it's the intro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so rather than get into more detail here, what about dropping that you can name them whatever you want entirely:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done here, Ben!