-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unflag hybrid rendering docs #3353
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sure! Go for it! I see maybe a possible logical flow as:
|
(And, if you don't get around to it, just uncommenting the experimental flag would be fine, too!) 😄 |
Ok, I think it's worth trying to combine too. I'll make a pass and if you don't like it the commit can just be removed. |
@sarah11918 Took a pass at it, let me know what you think. |
Hi @matthewp - I made #3378 as a PR to your branch since I found I wanted to edit some things outside of your changes here. For example we still had the bold line about every page being server-rendered once you enable SSR, which isn't true anymore. I took the take that both modes are a way to get some (or all) SSR into your project, and defined/described them as such. There's a lot that's parallel between the two so thinking of them, and structuring the page that way is quite clean. We might decide we don't like that, but I think there's ultimately some value in that clarity, so I wanted to consider it. (Framing it that way vs hybrid rendering being it's own weird thing does make me think that the name See what you think in the other PR, and like I wrote there, it doesn't have to be the final call. But if we like that structure/framing, then we can take this from there. |
Also, just a reminder for us that there should be a corresponding |
Co-authored-by: Nate Moore <[email protected]>
Happy with how this landed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy, too! 🥳
What kind of changes does this PR include?
Description