Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: note to direct users to modifiyng frontmatter with remark #3988

Merged
merged 4 commits into from
Jul 31, 2023
Merged

add: note to direct users to modifiyng frontmatter with remark #3988

merged 4 commits into from
Jul 31, 2023

Conversation

carsakiller
Copy link
Contributor

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content

Description

  • Closes Not clear how to modify frontmatter programmatically #3930
  • What does this PR change? Give us a brief description.
    • It adds a note aside to the markdown-content page that warns users that if they are using content collections, they should instead be reading the content-collections page if they want to modify their frontmatter programmatically.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5ffb3f1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64c7ca8cea45df000883fe09
😎 Deploy Preview https://deploy-preview-3988--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carsakiller
Copy link
Contributor Author

Direct link to the note I have added

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for first filing a really helpful, detailed issue and then jumping on the fix, @carsakiller! 🚀

I kind of had to laugh when I followed your link, and got a huge DO NOT DO THIS warning, but... I mean, this is the proper place to direct people, so... 😂

I'm just going to commit the tiny tweak to the language directly here, and then we'll officially make you a member of Team Docs! 🥳

src/content/docs/en/guides/markdown-content.mdx Outdated Show resolved Hide resolved
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this lovely note @carsakiller 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not clear how to modify frontmatter programmatically
3 participants