Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr) Add French translation for content.mdx talks.mdx and update recipes.mdx and nav.ts #6684

Merged
merged 12 commits into from
Feb 1, 2024
Merged

i18n(fr) Add French translation for content.mdx talks.mdx and update recipes.mdx and nav.ts #6684

merged 12 commits into from
Feb 1, 2024

Conversation

McFlyPartages
Copy link
Contributor

@McFlyPartages McFlyPartages commented Jan 28, 2024 •
edited
Loading

Description (required)

Add French translation for content.mdx talks.mdx and update recipes.mdx and nav.ts

PR #5614 #6470

@vercel Vercel
Copy link

vercel bot commented Jan 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 1, 2024 0:11am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 28, 2024
@McFlyPartages
Update content.mdx
c6173dd 
Je ne sais pas trop si nous devons traduire les titres d'articles cela permet d'indiquer la langue pour le lecteur ?
@McFlyPartages
Create talks.mdx
a85bc4b
@McFlyPartages
Update recipes.mdx
1a481f7
@McFlyPartages
Update nav.ts
7440bfc
@McFlyPartages
Update nav.ts
6c69874
@McFlyPartages McFlyPartages changed the title [WIP] i18n(fr) Add French translation for content.mdx talks.mdx and update recipes.mdx and nav.ts i18n(fr) Add French translation for content.mdx talks.mdx and update recipes.mdx and nav.ts Jan 28, 2024
thomasbnt
thomasbnt requested changes Jan 28, 2024
View reviewed changes
Copy link
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One link to fix, and LGTM!

@McFlyPartages
Copy link
Contributor Author

One link to fix, and LGTM!

Thanks it's ok

thomasbnt
thomasbnt approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasbnt
Copy link
Member

Owh, miss CI Links and good!

thomasbnt
thomasbnt approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VoxelMC
Copy link
Contributor

VoxelMC commented Jan 29, 2024

Thanks!!

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and it LGTM!

dreyfus92
dreyfus92 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci les gars, LGTM 😁

@dreyfus92 dreyfus92 merged commit 91d3dc3 into withastro:main Feb 1, 2024
7 checks passed
@McFlyPartages McFlyPartages deleted the up_fr_content branch February 1, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasbnt thomasbnt thomasbnt approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@McFlyPartages @thomasbnt @VoxelMC @dreyfus92