-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that getHeadings() only applies to the MDX file, not childre… #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Closed
1 task
sarah11918
reviewed
Mar 15, 2024
sarah11918
reviewed
Mar 15, 2024
sarah11918
added
improve or update documentation
Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Merge Queue
Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
labels
Mar 15, 2024
sarah11918
reviewed
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improve or update documentation
Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Merge Queue
Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Adding docs for
getHeadings()
that it only includes the headings in the file. For MDX you might have child components that contain headings but those are not included ingetHeadings()
.Related issues & labels (optional)
headings
prop not being properly populated with nested<Content />
astro#10447