Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all mentioned jsconfig #8818

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Conversation

liruifengv
Copy link
Member

Description (required)

Remove all mentioned jsconfig

Related issues & labels (optional)

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e97042
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/669748fa31b68b0008a20078
😎 Deploy Preview https://deploy-preview-8818--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jul 16, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/imports.mdx Source changed, localizations will be marked as outdated.
en guides/typescript.mdx Source changed, localizations will be marked as outdated.
en guides/upgrade-to/v1.mdx Source changed, localizations will be marked as outdated.
en reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thank you @liruifengv ! 🚀

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jul 16, 2024
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@liruifengv
Copy link
Member Author

!coauthor

Copy link

Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Paul Valladares <[email protected]>

@liruifengv liruifengv merged commit 8267745 into withastro:main Jul 17, 2024
11 checks passed
@liruifengv liruifengv deleted the jsconfig-del branch July 17, 2024 04:49
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jul 17, 2024
* Remove all mentions of jsconfig in French guides and references
(see withastro#8818)

Note: `src/content/docs/en/guides/upgrade-to/v1.mdx` is not included
since it does not exist yet. I'll update the translation in withastro#8772.
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jul 17, 2024
yanthomasdev added a commit that referenced this pull request Jul 19, 2024
* i18n(fr): remove jsconfig mentions in guides and references

* Remove all mentions of jsconfig in French guides and references
(see #8818)

Note: `src/content/docs/en/guides/upgrade-to/v1.mdx` is not included
since it does not exist yet. I'll update the translation in #8772.

* i18n(fr): add changes from minor release docs

Add changes only for `reference/cli-reference.mdx`.
See #8796

---------

Co-authored-by: Yan <[email protected]>
yanthomasdev added a commit that referenced this pull request Jul 19, 2024
* i18n(fr): add upgrade-to/v2.mdx

* i18n(fr): add upgrade-to/v1.mdx

* i18n(fr): add upgrade-to/v4.mdx

* i18n(fr): fix typo in errors/invalid-get-static-paths-entry.mdx

* i18n(fr): add upgrade-to/v3.mdx

* i18n(fr): fix broken links in upgrade-to/v3 and upgrade-to/v4

* i18n(fr): remove jsconfig mention in upgrade-to/v1.mdx

See #8818

* Update src/content/docs/fr/guides/upgrade-to/v2.mdx

Co-authored-by: Thomas Bonnet <[email protected]>

* i18n(fr): fix broken link to configuration-reference.mdx

---------

Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Thomas Bonnet <[email protected]>
Co-authored-by: Yan <[email protected]>
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-improvement Response to widget/Discord feedback improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it true that you can use a jsconfig.json ?
4 participants