-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): document new i18n logic #9133
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico Take a look at what I've done and see what you think!
The existing Fallback content needed some revising anyway, because it described the existing behaviour of redirects everywhere.
Since this isn't a reference page, and we have full config reference items we can link to for fallback
and fallbackType
, this page can simply tell the story of what a fallback strategy looks like.
(Note, I will actually want to revisit the rest of this page in the same way at some point, but for now, let's just get the fallback in place!)
Let me know what you think of this, and whether seeing the big picture like this makes you want to e.g. move the option from i18n.routing
and instead maybe rethink adding to fallback
itself? When you look at what it takes to configure this, and how it is explained, you might think of a better way config could look to achieve a more complete fallback outcome. (setting in two places like this might seem a little clunky)
But, see what you think and let me know!
Thank you @sarah11918 , I approve your new edits! |
Noting that the link check should pass once the new config reference docs have been pulled in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're in a good place here! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
!coauthor |
|
Description (required)
This PR documents
i18n.routing.fallbackType
, a new feature that will change how the fallback works.For Astro version:
4.15.0
. See astro PR #11677