Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix entry variable #9188

Merged
merged 2 commits into from
Aug 25, 2024
Merged

docs: fix entry variable #9188

merged 2 commits into from
Aug 25, 2024

Conversation

fbuireu
Copy link
Contributor

@fbuireu fbuireu commented Aug 24, 2024

Description (required)

Fixes the documentation in the Querying and rendering with the Content Layer API section section, where a variable named entry was used without a prior definition. It has been updated to correctly reference the post variable instead.

image

Username of Astro Discord: fbuireu

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 73a1963
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66caef2c2f3ec50008da058c
😎 Deploy Preview https://deploy-preview-9188--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 24, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/configuration-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Welcome to team docs 🥳

@TheOtterlord TheOtterlord merged commit 0eecf84 into withastro:main Aug 25, 2024
10 checks passed
@ArmandPhilippot
Copy link
Member

Thanks for this fix @fbuireu, and welcome! 🎉

Just a side note about configuration-reference.mdx contents. This file is auto-generated from JSDoc comments in withastro/astro repository (see Where to find docs source content). To avoid your fix being overwritten the next time the file is generated, the PR should be made on withastro/astro repository.
However, in this case, the same fix (withastro/astro#11814) is already awaiting approval, so that's not a problem. 😉

@TheOtterlord
Copy link
Member

Haha, thanks. I missed the filename 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants