Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to vite/client with astro/client #953

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 8, 2022

What kind of changes does this PR include?

  • New or updated content

Description

In withastro/astro#3851 we are replacing vite/client types with our own astro/client. This is so that we can make changes to the types you see in frontmatter.

This updates our docs to reflect the new location.

@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4aaff4c
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62cc84f368757f0009611905
😎 Deploy Preview https://deploy-preview-953--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis
Copy link
Member

delucis commented Jul 8, 2022

Thanks @matthewp! Could you remove the changes from non-/en/ pages? We usually leave those to our translators so they can make sure all the surrounding context gets updated correctly (some of the updated code samples still mention “Vite” in their accompanying comments for example).

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jul 9, 2022
@matthewp
Copy link
Contributor Author

@delucis If you'd like, but the changes are almost definitely correct and not making the changes means that they are for sure wrong. Would it be better to merge this and if for some reason there's a problem fix that than to leave in docs that we know are wrong?

@delucis
Copy link
Member

delucis commented Jul 11, 2022

The issue is that the comments provide context to the code updates and also need updating, e.g. here in Portuguese mentioning “Vite”:

image

If we merge this as-is, we’ll mark these translations as “up-to-date” in our automated translation tracker (#438) so our translators will never know they need updating.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewp! LGTM 🙌

@matthewp matthewp merged commit 49fe58f into main Jul 11, 2022
@matthewp matthewp deleted the client-types branch July 11, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants