Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssh-keygen): add completion spec #1569

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Conversation

SerpentBytes
Copy link
Contributor

@SerpentBytes SerpentBytes commented Oct 4, 2022

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds missing completion specs.

What is the current behavior? (You can also link to an open issue here)

Currently missing completion specs for ssh-keygen command. Closes #1535.

What is the new behavior (if this is a feature change)?

Implement specs for ssh-keygen

Additional info:

See man ssh-keygen

First time contributing during Hacktoberfest.

@withfig-bot
Copy link
Collaborator

Overview

src/ssh-keygen.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @SerpentBytes,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @SerpentBytes! I just have one small comment to address.

src/ssh-keygen.ts Show resolved Hide resolved
@fedeci fedeci changed the title feat(ssh-keygen) Add completion specs feat(ssh-keygen): add completion spec Oct 4, 2022
Co-authored-by: Federico Ciardi <[email protected]>
@fedeci fedeci added the hacktoberfest-accepted Accepted PR for Hacktoberfest label Oct 4, 2022
@fedeci fedeci merged commit 247dc86 into withfig:master Oct 4, 2022
@fedeci
Copy link
Contributor

fedeci commented Oct 4, 2022

Thanks!

@SerpentBytes
Copy link
Contributor Author

Thank you for allowing me to contribute to this project. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PR for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ssh-keygen] missing spec
3 participants