-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add taplo completion spec #1713
Conversation
Overviewsrc/taplo.ts:Info: |
Hello @batunpc,
Please add a 👍 as a reaction to this comment to show that you read this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @batunpc! I left some comments to solve before merging the PR, but overall it seems good to me!
args: { | ||
name: "CONFIG", | ||
template: "filepaths", | ||
suggestCurrentToken: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestCurrentToken: true, | |
suggestCurrentToken: true, | |
template: "filepaths", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here template: "filepaths",
is above the suggestCurrentToken
Would you like me to swap their places ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indifferent in a JS object. For styles we want to enforce we create eslint rules, so it npm run lint
does not complain it is good to go!
Thank you @fedeci I have addressed the requested changes in my last commit 9d4467f and left a comment for #1713 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes #1532
What is the current behavior? (You can also link to an open issue here)
The completion spec does not exist for taplo
What is the new behavior (if this is a feature change)?
autocomplete will be supported for taplo
Additional info:
I used
taplo --help
as reference to work with all the subcommands and options. Also used thetaplo <subcommand> --help
which produces different manual for each corresponding subcommands and option(s) in taplo.Autocompletion for
taplo
in action;