-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arduino-cli): add completion spec #2231
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Overviewsrc/arduino-cli.ts:Info: |
Hello @lukejans,
Please add a 👍 as a reaction to this comment to show that you read this. |
Hi @lukejans! Love this contribution, thanks for submitting - can you remove the yarn.lock file from this PR, so we can get this merged in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec looks good, one change I would suggest before merge is to remove all the example
in description where it is the full CLI command. Left some comments as examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
arduino-cli completion spec