Fix wixperiments debugging #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugging wixperiments fails with ``` Error running 'Bazel build :wixperiments_dev' Plugin file 'external/scala_2024_1/Scala/lib/bsp4j-2.1.0-M3.jar' not found. Did the build fail? ``` This happens at https://github.com/wix-playground/intellij/blob/wix-master/plugin_dev/src/com/google/idea/blaze/plugin/run/BlazeIntellijPluginDeployer.java#L189 It searches deploy file execution path (`external/scala_2024_1/Scala/lib/bsp4j-2.1.0-M3.jar`) within build artifacts relative paths which is `darwin_x86_64-fastbuild/Scala/lib/bsp4j-2.1.0-M3.jar` and cannot find it Build artifact files are pupulated here https://github.com/wix-playground/intellij/blob/wix-master/base/src/com/google/idea/blaze/base/command/buildresult/OutputArtifactParser.java#L80 Add special treament for external files so deployer can find it.
github-actions
bot
added
awaiting-review
product: CLion
product: IntelliJ
product: GoLand
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging wixperiments fails with
This happens at https://github.com/wix-playground/intellij/blob/wix-master/plugin_dev/src/com/google/idea/blaze/plugin/run/BlazeIntellijPluginDeployer.java#L189
It searches deploy file execution path (
external/scala_2024_1/Scala/lib/bsp4j-2.1.0-M3.jar) within build artifacts relative paths which isdarwin_x86_64-fastbuild/Scala/lib/bsp4j-2.1.0-M3.jarand cannot find itBuild artifact files are pupulated here https://github.com/wix-playground/intellij/blob/wix-master/base/src/com/google/idea/blaze/base/command/buildresult/OutputArtifactParser.java#L80
Add special treament for external files so deployer can find it.