Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fixed legacy Slider in debug mode #4366

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

gosha212
Copy link
Contributor

Description

  • This pull request addresses the issue described here: Legacy slider error in debug builds

In this pull request, I have …


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@noomorph noomorph changed the title Fixed legacy slider test(e2e): fixed legacy Slider in debug mode Feb 11, 2024

let LegacySlider;
try {
LegacySlider = require('react-native').Slider;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pack it up nicely under a tryRequire()? 🤔

@gosha212 gosha212 merged commit f4c6593 into master Feb 13, 2024
3 checks passed
d4vidi added a commit that referenced this pull request Feb 25, 2024
This reverts commit f4c6593, reversing
changes made to 546d07f.
d4vidi added a commit that referenced this pull request Feb 25, 2024
* Revert "Merge pull request #4366 from wix/bugfix/update_slider"

This reverts commit f4c6593, reversing
changes made to 546d07f.

* Revert "Merge pull request #4369 from wix/bugfix/broken-post-install"

This reverts commit 3083a58, reversing
changes made to b6aaf30.

* Revert "Upgrade/rn73 (#4347)"

This reverts commit bbcb472.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants