-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotIndicator is shown on the next tab when badge in null on ios #7146
Comments
you should set this options for bottomTab, not for bottomTabs |
yes, mistake in the description, fixed |
This is happening to me as well. Strange behavior. Component IDs look right, but the This along with that, I'm running in circles and becoming cuckoo lol. |
Ok I did run some other tests, and it does not seem to be related to Hope this helps. |
…ng tab button (#7684) Fix the bottomTab dotIndicator is displayed at a wrong tab button after changing the badge state. Related issue: #7146 ### Repro It happens after we modify the badge option by calling `mergeOptions` . https://user-images.githubusercontent.com/25456520/218294543-57d214ec-322f-40c2-9dce-bd4a86fd8354.mp4 ### Solution Fix `getTabView` to return the correct view at the given index. It currently uses `subviews` to find the view at index, but it doesn't work after tab bar buttons are modified. Fixed it by using `tabBarItemViewAtIndex` which is already implemented.
…ng tab button (#7684) Fix the bottomTab dotIndicator is displayed at a wrong tab button after changing the badge state. Related issue: #7146 ### Repro It happens after we modify the badge option by calling `mergeOptions` . https://user-images.githubusercontent.com/25456520/218294543-57d214ec-322f-40c2-9dce-bd4a86fd8354.mp4 ### Solution Fix `getTabView` to return the correct view at the given index. It currently uses `subviews` to find the view at index, but it doesn't work after tab bar buttons are modified. Fixed it by using `tabBarItemViewAtIndex` which is already implemented.
dotIndicator is shown on the next tab when badge is null on ios
To Reproduce
Expected behavior
dotIndicator is shown for componentId tab
Actual Behavior
dotIndicator is shown for the next tab
Your Environment
The text was updated successfully, but these errors were encountered: