Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to acknowledge answers #12

Merged
merged 4 commits into from
Jun 6, 2019
Merged

Add method to acknowledge answers #12

merged 4 commits into from
Jun 6, 2019

Conversation

ammaraskar
Copy link
Contributor

@ammaraskar ammaraskar commented May 18, 2019 •
edited
Loading

Tested on a Feather M0, please check locally if you can.

@orangeturtle739
Copy link
Collaborator

Resolves #11, #3.

@wizard97
Copy link
Owner

Awesome, give me a few days to play around with this, then I'll merge it.

@ammaraskar
Copy link
Contributor Author

@wizard97 This should be good to go now. Tested and working, I changed the defaults for the capture sketch since I figured the W module is more common, lemme know if you want me to revert or not have it SEND_ACKS by default.

Sorry for how long it took, RF_FIFOTHRESH_TXSTART_FIFOTHRESH_IC made the radio chip hang since it was expecting one more byte to send the packet.

wizard97
wizard97 requested changes Jun 5, 2019
View reviewed changes
Copy link
Owner

@wizard97 wizard97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! This all looks great, just a couple potential issues with how the length registers used by the radio for the sync address length and payload length are being set.

emulator/iSkipper/iClickerEmulator.h Outdated Show resolved Hide resolved
emulator/iSkipper/iClickerEmulator.h Outdated Show resolved Hide resolved
emulator/iSkipper/iClickerEmulator.cpp Show resolved Hide resolved
emulator/iSkipper/iClickerRadio.h Outdated Show resolved Hide resolved
emulator/iSkipper/examples/capture/capture.ino Show resolved Hide resolved
wizard97
wizard97 requested changes Jun 6, 2019
View reviewed changes
Copy link
Owner

@wizard97 wizard97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these... two last things. I think you made a typo, and also I just realized you were printing in an ISR. Just fix these two things and I'll merge right away.

emulator/iSkipper/iClickerEmulator.h Outdated Show resolved Hide resolved
emulator/iSkipper/examples/capture/capture.ino Outdated Show resolved Hide resolved
@wizard97
Copy link
Owner

wizard97 commented Jun 6, 2019

Looks great! Thank you!

@wizard97 wizard97 merged commit edf230f into wizard97:master Jun 6, 2019
@wizard97 wizard97 mentioned this pull request Jun 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizard97 wizard97 wizard97 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammaraskar @orangeturtle739 @wizard97