commands: use unconfirmed coins from self for coin selection #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change value here: |
|
Ah, that's been changed as part of #1498. But I don't think that change is required in this PR as the logic for specifying candidates for selection is in the remote backend API handler so will need to be changed there separately. |
|
Ah right thanks, I merged it, can you rebase ? |
We previously used unconfirmed change as a best-guess way of identifying those coins from self, but now we have the `is_from_self` field we can use it directly and be sure we only select coins that are fully under our control.
jp1ac4
force-pushed
the
coin-selection-use-unconfirmed-from-self
branch
from
ba1f3c4 to
091d772
Compare
|
Rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #1484.
We previously used unconfirmed change for coin selection as a best-guess way of identifying those unconfirmed coins from self, but now we have the
is_from_selffield we can use it directly and be sure we only select coins that are fully under our control.