Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gatsby v3 and update peerDependencies 🚑 #173

Merged
merged 2 commits into from
Mar 30, 2023
Merged

add gatsby v3 and update peerDependencies 🚑 #173

merged 2 commits into from
Mar 30, 2023

Conversation

TheeMattOliver
Copy link
Contributor

@TheeMattOliver TheeMattOliver commented Mar 6, 2021

Description

gatsby-plugin-intl won't work with Gatsby V3 bc it has out of date peer dependencies.

Updating to Gatsby V3 should be pretty easy, hopefully, and just be a matter of updating the peer deps in the package repo.

Gatsby3.0 Migration docs

Updating dependencies

Please update peer deps and let us know what else we can do to help. 👍

Fixes # (issue)

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: [email protected]
npm ERR! node_modules/gatsby
npm ERR!   gatsby@"3.0.3" from the root project
npm ERR!   peer gatsby@"^3.0.0-next.0" from [email protected]
npm ERR!   node_modules/gatsby-plugin-manifest
npm ERR!     gatsby-plugin-manifest@"3.0.0" from the root project
npm ERR!   9 more (gatsby-plugin-offline, gatsby-plugin-react-helmet, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer gatsby@"^2.0.0" from [email protected]
npm ERR! node_modules/gatsby-plugin-intl
npm ERR!   gatsby-plugin-intl@"^0.3.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@AleC77
Copy link

AleC77 commented Mar 9, 2021

any update?

@TheeMattOliver
Copy link
Contributor Author

any update?

Nothing -- seems that the maintainer has kind of abandoned the project.

@admkopec
Copy link

admkopec commented Apr 2, 2021

@TheeMattOliver, I believe you might have a bug in your fix, as now the package.json file has two entries for peerDependencies (one at line 26 – added by you, and one at line 41) The latter still points to "gatsby": "^2.0.0", and unfortunately that version appears to be required by npm (v7.5.4). You should remove the second entry and update this pull request, as that should fix the error thrown by npm. I have checked it at my fork and it appears to be working properly.

Copy link

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge 🙇

@whyboris
Copy link

whyboris commented Feb 4, 2023

@wiziple -- this seems like a great improvement to your excellent plugin 😊

I've even tested against Gatsby 5 and your plugin still works 🚀

Would you be willing to merge a PR for Gatsby 5 if I create one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants