Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about setuptools branch #59

Closed
wants to merge 1 commit into from

Conversation

nicholasjng
Copy link
Collaborator

Similar to the already existing note on the Bazel branch.

I pushed this to make my findings on setuptools-powered nanobind extension builds available to interested users. This is work in progress, but builds already on my machine, and follows the custom builds user guide in nb_combined.cpp on Linux.


Contains my research on a pybind11 migration project I'm doing on the side. If there is interest on your part, I can also write a small explanatory guide on setuptools for the nanobind docs. I'm aware that CMake is the preferred build system, but I figured that removing hurdles for getting users of other packaging solutions on board can be worth it.

Similar to the already existing note on the Bazel branch.

I pushed this to make my findings on setuptools-powered nanobind extension builds
available to interested users. This is work in progress, but builds already on my
machine, and follows the custom builds user guide in `nb_combined.cpp` on Linux.
@wjakob
Copy link
Owner

wjakob commented Jan 10, 2025

I think that setuptools is something from which many people are trying to actively move away. Adding all the details needed to compile nanobind code in every project (instead of abstracting them away into a separate package) makes this somewhat messy, and the dynamic nature of the setup.py causes many issues. So I think I prefer not advertising this.

@nicholasjng
Copy link
Collaborator Author

Makes sense, thanks!

@nicholasjng nicholasjng deleted the add-note-about-setuptools branch January 10, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants