Skip to content

Commit

Permalink
Enable WinMDExp task on .NET Core MSBuild
Browse files Browse the repository at this point in the history
This task will fail at runtime unless the .NET Framework
SDK is installed, since winmdexp.exe is only present in
that SDK. However, nothing about the task itself is
incompatible with .NET Core.

See also microsoft/microsoft-ui-xaml#1891.
Contributes to dotnet/sdk#3042.
  • Loading branch information
wjk committed Jan 27, 2020
1 parent 8aa0b87 commit 182174b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Tasks/Microsoft.Build.Tasks.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@
<Compile Include="RoslynCodeTaskFactory\RoslynCodeTaskFactoryCodeType.cs" />
<Compile Include="RoslynCodeTaskFactory\RoslynCodeTaskFactoryCompilers.cs" />
<Compile Include="RoslynCodeTaskFactory\RoslynCodeTaskFactoryTaskInfo.cs" />
<Compile Include="SdkToolsPathUtility.cs" />
<Compile Include="System.Design.cs" />
<Compile Include="system.design\stronglytypedresourcebuilder.cs" />
<Compile Include="TaskExtension.cs">
Expand All @@ -500,6 +501,7 @@
<Compile Include="Warning.cs">
<ExcludeFromStyleCop>true</ExcludeFromStyleCop>
</Compile>
<Compile Include="WinMDExp.cs" />
<Compile Include="XslTransformation.cs" />
<Compile Include="AssignCulture.cs" />
<Compile Include="Culture.cs" />
Expand Down Expand Up @@ -623,7 +625,6 @@
<ExcludeFromStyleCop>true</ExcludeFromStyleCop>
</Compile>
<Compile Include="ResolveSDKReference.cs" />
<Compile Include="SdkToolsPathUtility.cs" />
<Compile Include="RequiresFramework35SP1Assembly.cs" Condition="'$(MonoBuild)' != 'true'">
<ExcludeFromStyleCop>true</ExcludeFromStyleCop>
</Compile>
Expand All @@ -649,7 +650,6 @@
<Compile Include="UpdateManifest.cs" Condition="'$(MonoBuild)' != 'true'">
<ExcludeFromStyleCop>true</ExcludeFromStyleCop>
</Compile>
<Compile Include="WinMDExp.cs" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<Compile Include="XamlTaskFactory\CommandLineGenerator.cs" />
Expand Down

0 comments on commit 182174b

Please sign in to comment.