Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install error on other language Windows #1509

Closed
ladofa opened this issue Nov 5, 2024 · 9 comments · Fixed by #1525
Closed

pip install error on other language Windows #1509

ladofa opened this issue Nov 5, 2024 · 9 comments · Fixed by #1525

Comments

@ladofa
Copy link

ladofa commented Nov 5, 2024

Provide environment information

conda of python 3.12.4

What OS are you using?

Windows 10 (Korean)

Describe the Bug

pip install labelme
-> doesn't work on Korean Windows 10/11

Expected Behavior

The reason comes from setup.py open() function.
Korean python uses cp949 encoding in default.
open of line 14 and 73 should be have encoding='utf-8' option.

To Reproduce

No response

@YejinHwang909
Copy link

YejinHwang909 commented Nov 19, 2024

@ladofa
can you modify setup.py?

def get_long_description():
    with open("README.md", encoding="utf-8") as f:
        long_description = f.read()

It works for me.

@ladofa
Copy link
Author

ladofa commented Nov 19, 2024

@ladofa can you modify setup.py?

def get_long_description():
    with open("README.md", encoding="utf-8") as f:
        long_description = f.read()

It works for me.

yeah i already did it for me, i am asking for

pip install labelme 😉

@ladofa ladofa closed this as completed Nov 19, 2024
@ladofa ladofa reopened this Nov 19, 2024
@YejinHwang909
Copy link

YejinHwang909 commented Nov 20, 2024

@ladofa
How about going to the labelme folder and running the pip install . command?

@ladofa
Copy link
Author

ladofa commented Nov 20, 2024

@ladofa How about going to the labelme folder and running the pip install . command?

Thank you for your kind reply.
I already knew how to solve.

I'm asking for my students and all people,
not to you YejinWhang, but to the developer wkentaro.
Please fix it.

@ltminnovator
Copy link

I have just encountered the same issue on a Windows 11 Pro 23H2 computer. I use English system settings but the original Windows install was the Traditional Chinese version.

Thank you for the info on how to workaround, but I work with non-programmers who tend to struggle with simple technical instructions, and would like to avoid any complications in future

@taken-yjyoon
Copy link

yeap... this is a problem, and happeded to me also, and while I can fix it myself, I have to work with someone whose not good at tech, so... please?

however, there is an alternative method that have worked for me that is using conda to install everything, and then install pyqt5 separatively

conda install labelme -c conda-forge
pip install pyqt5-tools

@wkentaro
Copy link
Owner

wkentaro commented Jan 9, 2025

Sorry for being late. Will be fixed by #1525

wkentaro added a commit that referenced this issue Jan 9, 2025
@ladofa
Copy link
Author

ladofa commented Jan 9, 2025

Sorry for being late. Will be fixed by #1525

I am always grateful to you for creating this program. Wishing you a Happy New Year!

@wkentaro
Copy link
Owner

wkentaro commented Jan 9, 2025

You too, Iadofa! Will try being more prompt this year :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants