-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release engineering improvements #1844
Release engineering improvements #1844
Conversation
bb0f89c
to
a679697
Compare
636e52f
to
04ae0e4
Compare
04ae0e4
to
4c5dcde
Compare
Nice! Will be nice to have the build output scripts working more reliably. |
0d24f1f
to
844923a
Compare
844923a
to
3b1abb0
Compare
This is a whole slew of great improvements! The codename is changed infrequently and could use the same logic as Once again, awesome work 👍 |
Works very well overall! |
The idea was that it is always set for the 4 common envs we release now (via https://github.com/Aircoookie/WLED/blob/master/.github/workflows/wled-ci.yml#L55-L57) but you can set it via shell if you want a release binary name for one-offs with something like:
|
Some release engineering improvements.
package.json
. One less place to modify version number. Open to suggestions on better managing the version.build_output
folder structure they have been combined and more generalized.output_bins.py
script to generate release binaries inbuild_output/release
if the env variableWLED_RELEASE
is set to something (such asWLED_RELEASE=1
).requirements.in
andrequirements.txt
to help version the PlatformIO environment. Therequirements.in
file is used bypip-tools
to updaterequirements.txt
.WLED_RELEASE_NAME
) to the release. When commiting and then pushing first usinggit push --tags
the release gets created as a draft which uploads the assets but gives opportunity to edit before publishing. You can also publish a release tag in the interface and it will run and upload the binaries to that existing release based on same tag.We also have
VERSION
(the dated version build code) andWLED_COENAME
in C++ headers. Thoughts about removing these and making them available inplatformio.ini
instead so they are more readily available to the build process and pipeline?