This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
tests: ensure init.spec mocks used getUrl method #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiese
force-pushed
the
promise-rejection-fail
branch
from
63b7cb3 to
46c72ff
Compare
Previously, the used method was not mocked which caused the test to result in an unhandled promise - and as this was only a warning it stayed green. Bug: T212409
jakobw
approved these changes
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the used method was not mocked which caused the test to
result in an unhandled promise - and as this was only a warning it
stayed green.
Goes into #132
Bug: T212409