Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOUNDARY ERRATA] DEU ADM1 #2631

Closed
SvenVw opened this issue Nov 30, 2022 · 4 comments · Fixed by #2770
Closed

[BOUNDARY ERRATA] DEU ADM1 #2631

SvenVw opened this issue Nov 30, 2022 · 4 comments · Fixed by #2770
Assignees

Comments

@SvenVw
Copy link

SvenVw commented Nov 30, 2022

Describe the Error
The boundaries for DEU ADM1 seem to be not very accurate. The offset is for some cases > 2km compared with with ADM2 and other sources. It looks therefore that the scale of the source data used for ADM1 is not detailed enough.

Screenshots
Comparison between ADM1 (red), ADM2 (green) and OSM (Location: 10.50601,51.68217):

image

Additional context
An improvement can be to use the dataset from the German government: https://gdz.bkg.bund.de/index.php/default/digitale-geodaten/verwaltungsgebiete/nuts-gebiete-1-250-000-stand-31-12-nuts250-31-12.html. The download link is: https://daten.gdz.bkg.bund.de/produkte/vg/nuts250_1231/aktuell/nuts250_12-31.gk3.shape.zip
The license looks permissive: https://www.govdata.de/dl-de/by-2-0

@DanRunfola
Copy link
Member

Thank you!

That license does look like we could use it - at least very similar to CC-BY.

@lydiatroup @dfornatora could one of you grab this? I'm working on the gb 5 code revisions now :)

@lydiatroup
Copy link

We have used this license previously. I will assign someone to this issue to update our Germany ADM1 to use this source. Thank you for the suggestion!

@DanRunfola
Copy link
Member

@all-contributors add @SvenVw to ideas

@allcontributors
Copy link
Contributor

@DanRunfola

I've put up a pull request to add @SvenVw! 🎉

@lydiatroup lydiatroup self-assigned this Feb 12, 2023
@lydiatroup lydiatroup linked a pull request Feb 28, 2023 that will close this issue
DanRunfola added a commit that referenced this issue Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants