Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code table entry in 4.59, typo in template 4.78, #200

Closed
SibylleK opened this issue May 26, 2023 · 5 comments · Fixed by #203
Closed

Missing code table entry in 4.59, typo in template 4.78, #200

SibylleK opened this issue May 26, 2023 · 5 comments · Fixed by #203
Assignees
Milestone

Comments

@SibylleK
Copy link
Contributor

Details

In template 4.59 the entry for codeTable is missing for "Attribute of tile". It should be 4.241.
(The code table is only included in the Content of Octet 17 so far.)

There is a typo in GRIB template 4.78: the codeTable for "Atmospheric chemical constituent type" should be 4.230 instead of 4.23.

Requestor

Sibylle Krebber (DWD), @SibylleK

@amilan17 amilan17 self-assigned this May 26, 2023
@amilan17 amilan17 added this to the FT2023-2 milestone Jun 5, 2023
@amilan17
Copy link
Member

amilan17 commented Jun 7, 2023

@amilan17
Copy link
Member

amilan17 commented Jul 12, 2023

In template 4.59 the entry for codeTable is missing for "Attribute of tile". It should be 4.241.
(The code table is only included in the Content of Octet 17 so far.)

@SibylleK Can you provide more details about where/how it should be included? -- nm -- I figured it out..

amilan17 added a commit that referenced this issue Jul 12, 2023
@amilan17
Copy link
Member

@SibylleK I also updated 4.62 and 4.63 for the same reason. 

Can you please check the PR?

@amilan17 amilan17 linked a pull request Jul 12, 2023 that will close this issue
@SibylleK
Copy link
Contributor Author

Thank you @amilan17 !
I checked and reviewed the PR.

@amilan17
Copy link
Member

amilan17 added a commit that referenced this issue Jul 27, 2023
…59-typo-in-template-478

update branch issue #200
@amilan17 amilan17 moved this to Ready for FT Approval Procedure in GRIB2 Amendments Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants