Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code table 4.9: add an entry to encode a probability based on a quantile distribution instead of based on a threshold #247

Closed
sebvi opened this issue May 2, 2024 · 6 comments
Closed

Code table 4.9: add an entry to encode a probability based on a quantile distribution instead of based on a threshold #247

sebvi opened this issue May 2, 2024 · 6 comments
Assignees
@sebvi
Milestone
FT2024-2

Comments

@sebvi
Copy link
Contributor

sebvi commented May 2, 2024 •
edited
Loading

Initial request

The templates “4.5 Probability forecasts at a horizontal level or in a horizontal layer at a point in time” and “4.9 Probability forecasts at a horizontal level or in a horizontal layer in a continuous or non-continuous time interval” can be used to encode probability forecasts based on one or two threshold criteria. For instance, one can encode the probability of total precipitation of "at least 5mm" in the last 24h.

We would like to propose a new entry in the code table 4.9 to extend the applicability of the templates for probability forecasts with the probability of the parameter being within a certain quantile. This solution is not "ideal" since it slightly repurpose the meaning of the "lower" and "upper" limit in the templates but it has the advantage to not create completely new templates just to rename lower and upper limits to more genric terms.

Amendment details

Add to code table 4.9 – Probability type

Code Description
10 Probability of event within the quantile of the probability distribution function (see Note)

Note: When using entry 10, the lower limit is used to encode the quantile q (must be an integer between 0 and Q) while the upper limit is used to encode the total number of quantiles Q. This defines the probability of the parameter falling within quantile q. For instance, to encode the probability of falling within the 10th percentile, then q=10 and Q=100; to encode the probability of falling within the 1st tercile, then q=1 and Q=3.

Comments

No response

Requestor(s)

Sebastien Villaume (ECMWF)
Robert Osinski (ECMWF)

Stakeholder(s)

ECMWF

Publication(s)

Codes (WMO-No. 306), Volume I.2, GRIB code table 4.9 (update)

Expected impact of change

MEDIUM

Collaborators

No response

References

No response

Validation

No response
@amilan17 amilan17 added this to the FT2024-2 milestone May 2, 2024
@sebvi sebvi self-assigned this May 14, 2024
@amilan17
Copy link
Member

amilan17 commented May 14, 2024 •
edited
Loading

https://github.com/wmo-im/CCT/wiki/Teleconference.14.May.2024 notes:
Sebastien introduced the proposal; @sebvi to add examples

@amilan17
Copy link
Member

amilan17 commented Jun 5, 2024 •
edited
Loading

https://github.com/wmo-im/CCT/wiki/Teleconference.2024.June.4and5 notes:
team reviewed; @sebvi spell out "PDF"

@sebvi
Copy link
Contributor Author

sebvi commented Jun 24, 2024 •
edited
Loading

@amilan17: while updated Code table 4.9, I noticed that the note 3 was not updated to its final value and still read as "225d"

EDIT: it looks like none of the notes got their final value and editing in the respective table apparently

sebvi added a commit that referenced this issue Jun 24, 2024
@sebvi
#247 adding entry in COde table 4.9 and associated note
25adf20
@sebvi
Copy link
Contributor Author

sebvi commented Jun 24, 2024

branch created and updated

@amilan17
Copy link
Member

amilan17 commented Jun 25, 2024 •
edited
Loading

https://github.com/wmo-im/CCT/wiki/Teleconference.24and26.June.2024 notes:
branch is ready for validation

@amilan17
Copy link
Member

amilan17 commented Jul 2, 2024

https://github.com/wmo-im/CCT/wiki/Teleconference.24and26.June.2024 notes:
@sebvi update PDF acronym in proposal and branch

sebvi added a commit that referenced this issue Jul 2, 2024
@sebvi
#247 changing PDF acronym to probability distribution function
e50fbed
@amilan17 amilan17 mentioned this issue Jul 8, 2024
Merged
amilan17 added a commit that referenced this issue Jul 10, 2024
@amilan17 @efucile @sebvi
247 code table 49 add an entry to encode a probability based on a qua…
74c6a4b 
…ntile distribution instead of based on a threshold (#265)

* fix rebase conflict xml,txt files

* fix rebase conflicts 247 adding entry in COde table 4.9 and associated note

* fix rebase conflicts xml,txt files

* xml,txt files

* #247 changing PDF acronym to probability distribution function

* xml,txt files

* remove odd char

* xml,txt files

* xml,txt files

* remove datestamp from XML gen

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sebastien Villaume <[email protected]>
@amilan17 amilan17 moved this to Ready for FT Approval Procedure in GRIB2 Amendments Aug 22, 2024
amilan17 added a commit that referenced this issue Nov 7, 2024
@amilan17 @efucile
@sebvi @SibylleK @antoinemerle @marijanacrepulja
FT2024-2 GRIB2 (#273)
4b0faf0 
* xml,txt files

* 247 code table 49 add an entry to encode a probability based on a quantile distribution instead of based on a threshold (#265)

* fix rebase conflict xml,txt files

* fix rebase conflicts 247 adding entry in COde table 4.9 and associated note

* fix rebase conflicts xml,txt files

* xml,txt files

* #247 changing PDF acronym to probability distribution function

* xml,txt files

* remove odd char

* xml,txt files

* xml,txt files

* remove datestamp from XML gen

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sebastien Villaume <[email protected]>

* 253 new normal and tangential velocity.... (#270)

* xml,txt files

* xml,txt files

* issue #253 update branch

* xml,txt files

* Update GRIB2_CodeFlag_4_2_10_4_CodeTable_en.csv

53 and 54 for normal and tangential component of water velocity, as entry 52 is used in issue 244 for mixed layed depth.

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sibylle Krebber <[email protected]>

* 248 code table 4101 new entry in code table 4101 to extend the usage of templates 4105 4106 4107 and 4112 (#263)

* fix rebase conflict: 248 adding entry in Code Table 4.101 and associated note

* fix rebase of xml,txt files

* fix legacy conflict text

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>

* 244 new new mixed layer depth parameter in code table 42 discipline 10 1 (#262)

* issue #244 in NEW branch

* xml,txt files

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>

* 246 additional anomalies templates (#268)

* #246 adding template 4.128 to 4.136 and entries in code table 4.0

* rebase fix xml,txt files

* Update GRIB2_Template_4_129_ProductDefinitionTemplate_en.csv

Replace "to" with "-"

* xml,txt files

* Update GRIB2_Template_4_131_ProductDefinitionTemplate_en.csv

upper limit

* xml,txt files

* Update GRIB2_Template_4_134_ProductDefinitionTemplate_en.csv

"51-62" not as octetNo

* xml,txt files

* Update GRIB2_Template_4_136_ProductDefinitionTemplate_en.csv

upper limit and typo in line 47

* xml,txt files

* fix CSV

* xml,txt files

* Apply suggestions from code review

update see note references

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sibylle Krebber <[email protected]>

* 245 deprecate template 444 create rectified version as template 450 (#269)

* #245 deprecate template 4.44, create new corrected template 4.50 and update Code table 4.0 accordingly

* xml,txt files

* Update GRIB2_CodeFlag_4_0_CodeTable_en.csv

* xml,txt files

* Update GRIB2_Template_4_50_ProductDefinitionTemplate_en.csv

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>

* 250 code table 42 and 4238 new sourcesink entries in code table 4238 and a new parameter in code table 42 discipline 0 category 20 (#274)

* #250 adding entries in code table 4.22.0.20 and 4.238

* xml,txt files

* #250 updating entries to only keep sink and source (removing loss and gain)

* xml,txt files

* xml,txt files

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>

* 238 new precipitation type flag... (#267)

#238

* xml,txt files

* 271 remove date from xml script (#272)

* xml,txt files

* Update create_master_lists.py

Remove the generation of the 'generated' param to avoid complex merging process.

Now the xml header won't have the 'generated' param anymore

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>

* xml,txt files

* xml,txt files

* update branch for issue #238

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: antoineMerleEUM <[email protected]>

* 249 code table 14 43 and 46 adding new entries to better describe type of forecasting (#261)

#249 
* fix rebase conflict: 249 adding entries in code table 1.4, 4.3 and 4.6 with associated notes

* fix rebase of xml,txt files

* #249, add notes, change sample to example

* xml,txt files

* editorial, changed 23 to 22 in CF4.3

* xml,txt files

* Update GRIB2_CodeFlag_4_6_CodeTable_en.csv

Co-authored-by: Marijana Crepulja <[email protected]>

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Marijana Crepulja <[email protected]>

* Update notes/CodeFlag_notes.csv

* 251 code table 41 and 42 new category for thermodynamical properties in discipline land surface and associated parameters (#266)

* #251 adding entries in subtables of codec table 4.2

* fix rebase conflicts for xml,txt files

* change capitilization

* xml,txt files

* #251 add notes

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

add note number

* xml,txt files

* Update GRIB2_CodeFlag_4_2_0_4_CodeTable_en.csv

change note number again

* xml,txt files

---------

Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Enrico Fucile <[email protected]>

* 249 new2 (#275)

* Code table 1.4, 4.3 and 4.6: Adding new entries to better describe type of forecasting #249

* xml,txt files

---------

Co-authored-by: Enrico Fucile <[email protected]>

---------

Co-authored-by: Enrico Fucile <[email protected]>
Co-authored-by: Sebastien Villaume <[email protected]>
Co-authored-by: Sibylle Krebber <[email protected]>
Co-authored-by: antoineMerleEUM <[email protected]>
Co-authored-by: Marijana Crepulja <[email protected]>
@amilan17 amilan17 closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebvi sebvi

Labels
None yet
Projects
GRIB2 Amendments
Archived in project
Milestone
FT2024-2
Development

No branches or pull requests
2 participants
@sebvi @amilan17