Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples consistency #198

Closed
amilan17 opened this issue Mar 13, 2024 · 7 comments · Fixed by #201
Closed

Examples consistency #198

amilan17 opened this issue Mar 13, 2024 · 7 comments · Fixed by #201
Assignees

Comments

@amilan17
Copy link
Member

amilan17 commented Mar 13, 2024

I'm reviewing the examples for consistency and will use this issue to bring up questions that I have.

@amilan17 amilan17 self-assigned this Mar 13, 2024
@amilan17
Copy link
Member Author

  1. Is the links.type intended to describe the data format at that link or the type of link itself, which would mostly be "text/html".

@amilan17
Copy link
Member Author

  1. all records should have an created/updated dates that are in 2024

@amilan17
Copy link
Member Author

  1. Are there alternatives to using ISO codelists in concepts?
    e.g.
    { "concepts": [ { "id": "continual" } ], "scheme": "https://standards.iso.org/iso/19139/resources/gmxCodelists.xml#MD_FrequencyCode" }

@amilan17
Copy link
Member Author

  1. formats vs availableFormats
    In some of the examples there is a "formats" property. While technically legal, I think the way we should do as the standard says and put this in links.distribution.availableFormats

"formats": [ "GRIB2" ]

@amilan17
Copy link
Member Author

@wmo-im/tt-wismd I recently reviewed the example records, made some changes for consistency and added a lot of questions. Specific questions/requests are in the PR and general questions are above. It would be good to have these ready to post on schemas.wmo.int shortly after the next meeting on Monday.

#199

@amilan17
Copy link
Member Author

  1. Is the links.type intended to describe the data format at that link or the type of link itself, which would mostly be "text/html".

As discussed with Tom, the links.type property should represent what is returned when you click on the link. For example, if it's a WAF with a list of XML files then the type should be "text/html", but if clicking on the link returns an XML file, then the type should be "text/xml".

@tomkralidis
Copy link
Collaborator

A PR is put forth in #201 .

As discussed with Tom, the links.type property should represent what is returned when you click on the link. For example, if it's a WAF with a list of XML files then the type should be "text/html", but if clicking on the link returns an XML file, then the type should be "text/xml".

Per RFC7303, text/xml is an alias for application/xml, so we use the latter as required in WCMP2 and beyond.

tomkralidis added a commit that referenced this issue Mar 27, 2024
* update examples (#198)

* fix

* update media types

* Update examples/us-noaa-nws.goes16-satellite-sst.json

---------

Co-authored-by: Anna Milan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants