Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Registry function for node metadata management #26

Closed
wants to merge 10 commits into from

Conversation

kurt-hectic
Copy link

@kurt-hectic kurt-hectic commented Sep 1, 2023

  • Introduction of a Global Registry (GR) function to manage metadata needed by GB to discover registered WIS nodes and for WIS nodes to obtain source IP addresses of GB and GC
  • Procedures for WIS nodes to let GB and GC connect
  • Procedures for WIS, GC and GB to manage relevant metadata in the GR

added Global Registry as new infrastructure component
addded content to section what a WIS2 node needs to do to let GB and GC in
Content on how GB obtain information needed to connect to WIS2 nodes from the Global Registry and that GB and GC need to maintain information about IP addresses used to connect to WIS2 nodes in the Global Registry.
change WIS2 Node to WIS node
replace WIS2 node by WIS node. Editorials
@kurt-hectic kurt-hectic requested a review from golfvert September 1, 2023 11:49

=== Global Registry ===

* The roles of the Global Registry is to make available the information required for Global Infrastructure and WIS2 nodes to connect with each other.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to introduce the term" Global Infrastructure". I'd prefer to keep Global Services.
We also have to be consistent. Here WIS2 Node is used. In other PR it is WIS Node. So far we used WIS2 Nodes. That would be my preference.

=== Global Registry ===

* The roles of the Global Registry is to make available the information required for Global Infrastructure and WIS2 nodes to connect with each other.
* The Global Registry makes available to Global Caches the list of registered WIS2 Nodes. The following metadata is made available for each WIS2 Node: hostname and port(s) of local broker, center_id, list of implemented protocols (MQTT, MQTTs, web-socket).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Global Caches are not on the "front" of the connectivity. GBs are.
So, we could have "The Global Registry makes available to Global Services the list of registered WIS2 Nodes"

* The roles of the Global Registry is to make available the information required for Global Infrastructure and WIS2 nodes to connect with each other.
* The Global Registry makes available to Global Caches the list of registered WIS2 Nodes. The following metadata is made available for each WIS2 Node: hostname and port(s) of local broker, center_id, list of implemented protocols (MQTT, MQTTs, web-socket).
* The Global Registry makes available to WIS2 nodes the list of IP addresses used by Global Brokers and Global Caches to subscribe to and download data from WIS2 nodes.
* The Global Registry provides authorized contacts the means to update information about their WIS2 Node or Global Infrastrucure.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Infrastructure. Use Services.


This section describes the process used to register or remove a WIS node within WIS2. During the initial part of the WIS2 pilot phase, a Member simply needs to notify the WMO Secretariat and primary GISC of the intent to register a new WIS node. The Secretariat and GISC will then assist in the registration. More formal procedures will be developed as the number of WIS nodes increases.
This section describes the process used to register or remove a WIS2 node within WIS2. To register one or more WIS nodes, the Member responside for the node needs to be designated as a NC or DCPC.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIS or WIS2. I'd prefer WIS2.
Add at the end by the PR of the country.


TODO: to be completed
A WIS2 node shall allow at least one Global Broker and Global Cache to connect to its local broker and web storage. For this, the WIS2 node shall allow the outgoing IP addresses used by the Global Broker and Global Cache to establish connections to broker and web-storage, and allow the Global Cache to subscribe to the topic corresponding to this WIS2 node using the username and password combination "everyone/everyone".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least two of each... Redundancy.
No, Global Cache don't subscribe to WIS2 Node. Only to GB.
No one but GBs are subscribing to WIS2 Nodes, GC and GBs.

Replace by:

A WIS2 node shall allow at least two Global Broker to connect to its local broker and at least two Global Cache to its web storage. For this, the WIS2 node shall allow the outgoing IP addresses used by the Global Broker and Global Cache to establish connections to broker and web-storage, and allow the Global Broker to subscribe to the topic corresponding to this WIS2 node. Username and password used to protect the MQTT subscription will be part of the Global Registry.

TODO: to be completed
A WIS2 node shall allow at least one Global Broker and Global Cache to connect to its local broker and web storage. For this, the WIS2 node shall allow the outgoing IP addresses used by the Global Broker and Global Cache to establish connections to broker and web-storage, and allow the Global Cache to subscribe to the topic corresponding to this WIS2 node using the username and password combination "everyone/everyone".

The list of IP addresses used by Global Brokers and Caches can be obtained from the Global Registry. If a WIS2 node implements source IP filtering to grant a Global Broker and Global Cache access, it shall implement changes to its filterting within one month of the changes being published to the Global Registry.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of IP addresses used by Global Brokers and Caches can be obtained from the Global Registry. If a WIS2 node implements source IP filtering to grant Global Brokers and Global Caches access, it shall implement changes to its filtering within one month of the changes being published to the Global Registry.

addressed comments by Remy
changes requested by Remy (-username/password)
@kurt-hectic
Copy link
Author

@golfvert and @tomkralidis . Can this be merged? I believe all Remy's comments are addressed. When merging the Secretariat will make sure consistent terminology is used for nodes and services.

@tomkralidis
Copy link
Collaborator

@kurt-hectic

@tomkralidis
Copy link
Collaborator

@kurt-hectic @golfvert closing this PR and invite a new PR based on the new structure (and to resolve merge conflicts).

@tomkralidis tomkralidis closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants