Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and streamline repository #213

Closed
tomkralidis opened this issue Jul 26, 2022 · 2 comments
Closed

refactor and streamline repository #213

tomkralidis opened this issue Jul 26, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tomkralidis
Copy link
Collaborator

wis2box at present is built out as follows:

  • wis2box: Python package with docker setup for entire stack
  • wis2box-api: separate repository
  • wis2box-ui: separate repository

To streamline development and better represent functionality:

  • update wis2box repository into repo of docker components
  • docker-compose*.yml files at root
  • each component in its own top level directory (api, ui, auth, etc.)
  • move wis2box-api and wis2box-ui proper as top level directories into wis2box repo

This will also help in cutting a single version against a single repo as part release management.

@tomkralidis tomkralidis added the enhancement New feature or request label Jul 26, 2022
@tomkralidis tomkralidis added this to the sprint-006 milestone Jul 26, 2022
@tomkralidis tomkralidis self-assigned this Jul 26, 2022
@webb-ben
Copy link
Member

webb-ben commented Aug 1, 2022

I like the idea of restructuring the repository to have component folders at the root level.

For what its worth, I think wis2box-ui and wis2box-api are better left in separate repositories. Their respective directories could be compose file configuration for these images. It is my impression that including the source code for these components encumbers future modular growth.

How is this going to work with nginx configuration? Will python3 wis2box-ctl.py ... still have zero dependencies to run on a fresh install of python3?

@tomkralidis tomkralidis modified the milestones: sprint-006, sprint-007 Oct 2, 2022
@tomkralidis tomkralidis modified the milestones: sprint-007, sprint-008 Nov 15, 2022
@tomkralidis
Copy link
Collaborator Author

Implemented in #362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants