Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reported by Algeria: wis2box only read first message from ingested BUFR file #331

Closed
maaikelimper opened this issue Nov 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@maaikelimper
Copy link
Collaborator

"Recently, we noticed that not all of the station data was displayed on the WIS2BOX map. Upon further research, we learned that the system was only reading the first message from our BUFR files."

To reproduce issue, examble of bufr containing 5 messages in this zip:
msg00001637.zip

@maaikelimper maaikelimper added the bug Something isn't working label Nov 17, 2022
@david-i-berry
Copy link
Member

Issue in bufr2geojson, fixed by PR16 (wmo-im/bufr2geojson#16)

This is also likely present in the BUFR passthrough.

@tomkralidis tomkralidis changed the title Issue reported by Algera: wis2box only read first message from ingested BUFR file Issue reported by Algeria: wis2box only read first message from ingested BUFR file Nov 20, 2022
webb-ben added a commit that referenced this issue Nov 22, 2022
- Create separate functions to process individual messages (#331) and subsets.
- Throw away BUFR subsets missing data
- Write BUFR directly to bytestring
webb-ben added a commit that referenced this issue Nov 22, 2022
- Create separate functions to process individual messages (#331) and subsets.
- Throw away BUFR subsets missing data
- Write BUFR directly to bytestring
@webb-ben webb-ben mentioned this issue Nov 22, 2022
webb-ben added a commit that referenced this issue Nov 27, 2022
- Create separate functions to process individual messages (#331) and subsets.
- Throw away BUFR subsets missing data
- Write BUFR directly to bytestring
tomkralidis pushed a commit that referenced this issue Nov 28, 2022
* Split BUFR handling into separate functions

- Create separate functions to process individual messages (#331) and subsets.
- Throw away BUFR subsets missing data
- Write BUFR directly to bytestring

* Combine messages

cat algeria test BUFR files together into one file of ten messages

* Update bufr4 docstrings

- Update bufr4 docstrings
- Use bufr2geojson get_tsi() for traditional station identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants