SSL everywhere #403
Merged
SSL everywhere #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is currently running wis2box-zambia for testing: mosquitto_sub -d -L mqtts://everyone:[email protected]/origin/# |
Closed
tomkralidis
requested changes
Mar 3, 2023
| @@ -1,7 +1,7 @@ | |||
| services: | |||
| web-proxy: | |||
| ports: | |||
| - 8999:80 | |||
| - 80:80 | |||
There was a problem hiding this comment.
Should we move to port 80 by default, or leave this to be managed by the release process (which changes ports to port 80)?
docker-compose.yml
Outdated
| @@ -9,7 +9,7 @@ services: | |||
| depends_on: | |||
| - wis2box-ui | |||
| volumes: | |||
| - ./nginx/nginx.conf:/etc/nginx/nginx.conf:ro | |||
| - ./nginx/nginx-nossl.conf:/etc/nginx/conf.d/default.conf | |||
There was a problem hiding this comment.
Suggest to rename files of type -nossl without the suffix; example:
/nginx/nginx.conf(no SSL)/nginx/nginx-ssl.conf(SSL)
|
|
||
| .. code-block:: bash | ||
|
|
||
| WIS2BOX_SSL_CERT=/etc/letsencrypt/live/example.wis2box.io/fullchain.pem |
|
Changes:
I thought we agreed to use port 80 by default for override to reduce confusion within documentation ? |
|
@maaikelimper can you rebase against latest main (changes since last update)? |
ssl option in wis2box-ctl env-variables to share key and cert location initial docs mosquitto and nginx ssl/nossl http://localhost:8999 to http://localhost
maaikelimper
force-pushed
the
ssl-everywhere
branch
from
5176663 to
fb1e252
Compare
tomkralidis
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my first attempt at implementing SSL everywhere.
Basically I add add additional docker-compose-file to allow a user to share the SSL-cert and SSL-key with the nginx and mosquitto container.
To enable HTTPS and MQTTS on your wis2box run wis2box with the option '--ssl':
Which requires additional environment variables in dev.env:
Implements #140