Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify and overhaul the error handling of the different APIs #24

Closed
wneessen opened this issue Dec 22, 2022 · 0 comments · Fixed by #25
Closed

Verify and overhaul the error handling of the different APIs #24

wneessen opened this issue Dec 22, 2022 · 0 comments · Fixed by #25
Assignees
@wneessen
Labels
bug Something isn't working enhancement New feature or request

Comments

@wneessen
Copy link
Owner

As noted in #22 the error handling in all APIs are not perfect. This issue is meant to give all of the APIs an overhaul in terms of error handling similar to the fix that was already applied for #22.
@wneessen wneessen self-assigned this Dec 22, 2022
@wneessen wneessen added bug Something isn't working enhancement New feature or request labels Dec 22, 2022
wneessen added a commit that referenced this issue Dec 22, 2022
@wneessen
Overhauling error handling of the different APIs as part of #24
9c4b20b 
- Overhauled the breaches API
- Added more tests
wneessen added a commit that referenced this issue Dec 22, 2022
@wneessen
Overhauling error handling of the different APIs as part of #24
c5ea330 
- Generalized errors
- Updated version number and User-Agent string
- Made default timeout a const
wneessen added a commit that referenced this issue Dec 22, 2022
@wneessen
Overhauling error handling of the different APIs as part of #24
f143794 
- More error generalization
- Fixed PwnedPasswords API errors
- Added SHA1 hash validation with corresponding error
- More tests for error handling
@wneessen wneessen linked a pull request Dec 22, 2022 that will close this issue
Fix/24 verify and overhaul the error handling of the different apis #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wneessen wneessen

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/24 verify and overhaul the error handling of the different apis wneessen/go-hibp
1 participant
@wneessen