Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings #137

Closed
dhermes opened this issue Sep 19, 2018 · 3 comments
Closed

Fix some warnings #137

dhermes opened this issue Sep 19, 2018 · 3 comments

Comments

@dhermes
Copy link
Collaborator

dhermes commented Sep 19, 2018

.../nox/nox/sessions.py:35: DeprecationWarning: invalid escape sequence \w
  path = re.sub("[^\w\s-]", "-", path).strip().lower()

.../nox/nox/sessions.py:36: DeprecationWarning: invalid escape sequence \s
  path = re.sub("[-\s]+", "-", path)

.../nox/.nox/tests-3-7/lib/python3.7/site-packages/markupsafe/__init__.py:13: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Mapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html

@theacodes I wouldn't have seen this if I didn't make some tests fail. Worth changing how pytest is invoked so that warnings turn to errors?

The third is out of our control, but has been filed / fixed already: pallets/markupsafe#99

@theacodes
Copy link
Collaborator

Worth changing how pytest is invoked so that warnings turn to errors?

totally.

What are we using markupsafe for?

@dhermes
Copy link
Collaborator Author

dhermes commented Sep 19, 2018

It's part of jinja2

@theacodes
Copy link
Collaborator

theacodes commented Sep 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants