Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New global option nox.options.venv_backend to set the default backend #315

Closed
smarie opened this issue Apr 21, 2020 · 1 comment · Fixed by #316
Closed

New global option nox.options.venv_backend to set the default backend #315

smarie opened this issue Apr 21, 2020 · 1 comment · Fixed by #316

Comments

@smarie
Copy link
Contributor

smarie commented Apr 21, 2020

As you've understood from my recent activity on this repo, I am a conda user ;)

I like my noxfile.py but it could be much lighter if I did not have to write venv_backend="conda" everywhere.

Therefore I propose to define a new global option nox.options.venv_backend (or whatever alternate name you'll prefer of course)

@smarie
Copy link
Contributor Author

smarie commented Apr 22, 2020

Actually default_venv_backend will probably be more explicit.

theacodes pushed a commit that referenced this issue May 24, 2020
* New global option `nox.options.venv_backend` to set the default backend. Fixes #315

* Added doc about the new option

* Blackened

* fixed tests

* Fixed docs

* Fixed coverage by adding tests for the venv_backend_completer

* fixed test

* Added tests for short and long versions of the new option.

* Replaced the venv_backend completer with a simple `choices` from argparse :)

* Renamed venv_backend to default_venv_backend, and created new force_venv_backend

* New "none" choice for venv_backends, equivalent to python=False

* Updated doc concerning default_venv_backend and force_venv_backend, as well as the new 'none' backend

* Fixed all manifest tests

* Fixed test_tasks for venv_backend

* Fixed coverage

* Blackened code

* The warning message was appearing for all sessions, even those deselected. It is now only logged when session is run.

* Added `--no-venv` option. Fixes #301

* Blackened

* Fixed tests

* Improved coverage

* Blackened

* Fixed an issue with parametrization: warning would not be issued. Added corresponding tests. This should make coverage happy, too.

* Blackened

* Now `install` and `conda_install` work when there is no venv backend (or python=False). Previously a `ValueError` was raised. Fixes #318

* Fixed test

* Minor edit to trigger CI build again as it seems stuck.

* Minor doc fix to trigger the CI again (appveyor false fail)

Co-authored-by: Sylvain MARIE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant