Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uv python install only with uv backend #900

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Use uv python install only with uv backend #900

merged 3 commits into from
Jan 17, 2025

Conversation

oliversen
Copy link
Contributor

fix #899

@henryiii
Copy link
Collaborator

henryiii commented Dec 13, 2024 •
edited
Loading

I think a test needs updating too. Edit: actually, maybe it's our tests. Edit: Ahh, I think it's #902.

@henryiii henryiii force-pushed the fix-interpreter-resolver branch from 7c501ed to 87d398b Compare December 13, 2024 02:44
DiddiLeija
DiddiLeija approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess some coverage is required for the new behavior, but that's all what it's needed.

@henryiii henryiii force-pushed the fix-interpreter-resolver branch from 87d398b to d10d9f4 Compare January 15, 2025 03:12
@henryiii
Copy link
Collaborator

I've just marked this bit as nocover, since installing uv Python versions is a global operation and I don't think we want to require it in our tests.

@DiddiLeija
Copy link
Collaborator

Great! Then I think we're fine to merge :)

@henryiii henryiii merged commit a02eb79 into wntrblm:main Jan 17, 2025
24 checks passed
@henryiii henryiii mentioned this pull request Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiddiLeija DiddiLeija DiddiLeija approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nox installs Python using uv with non-uv backend
3 participants
@oliversen @henryiii @DiddiLeija