Fixed issue with paths not working on Windows OS #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path was assumed to have forward slashes when it was being split. This resulted in the path being wrong on Windows where paths are backslashes. The fix was to use the Node.js path library and get the OS specific separator. This fixes the issue on Windows and Unix operating systems which use a forward slash are unaffected. The error before applying this fix was: ``` node_modules\gulp-slate\index.js:189 throw new PluginError( FileOpenError: could not open include includes/_errors.md ```
wodka
added a commit
that referenced
this pull request
Mar 15, 2016
Fixed issue with paths not working on Windows OS
|
thanks :) I just release 1.0.6 to use this |
|
Thanks mate...Great to have a gulp plugin for slate. Good work. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path was assumed to have forward slashes when it was being split. This resulted in the path being wrong on Windows where paths are backslashes. The fix was to use the Node.js path library and get the OS specific separator. This fixes the issue on Windows and Unix operating systems which use a forward slash are unaffected.
The error before applying this fix was: