Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rfd deps and link to alternate implementation #7

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Jan 31, 2024

Hi,

Was going to create an issue to ask you before creating the pull request but since it was not much effort to make the PR I just did that and said we should be able to discuss here.

I created a version of your example that uses poll-promise and wanted to find out if you wouldn't mind linking to it so it's more discoverable. I figured yours is simpler to understand so I didn't want to replace yours hence why I made a separate one.

In doing that I had to fix the CI issues again and figured maybe ppl might have the issue locally as well. I didn't but I maybe already had the dependency installed. So I added it to the readme in mine and included the change I made to this PR.

Let me know what you think.

Thanks

@c-git
Copy link
Contributor Author

c-git commented Jan 1, 2025

Is this likely to get merged or should I close?

@woelper
Copy link
Owner

woelper commented Jan 2, 2025

I am very sorry, I must have missed this!
Thank you for your contribution!

@woelper woelper merged commit 6efd38b into woelper:main Jan 2, 2025
2 checks passed
@c-git
Copy link
Contributor Author

c-git commented Jan 2, 2025

Oh ok no problem, you're welcome.

@c-git c-git deleted the patch-1 branch January 2, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants