Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] Update pdfjs-dist to 4.0.379 #1690

Closed
wants to merge 1 commit into from
Closed

[breaking] Update pdfjs-dist to 4.0.379 #1690

wants to merge 1 commit into from
+80 −398

Conversation

wojtekmaj
Copy link
Owner

@wojtekmaj wojtekmaj commented Jan 4, 2024 •
edited
Loading

Closes #1664

Breaking changes:

  • Changed extension in workerSrc
  • Dropped support for svg renderMode
  • Dropped support for browsers not supporting structuredClone (e.g. Chrome <98) unless polyfilled

Blockers:

@wojtekmaj wojtekmaj force-pushed the pdfjs-dist-4.0.379 branch 3 times, most recently from d82d593 to 588ab0d Compare January 4, 2024 21:52
@wojtekmaj wojtekmaj force-pushed the pdfjs-dist-4.0.379 branch 3 times, most recently from d5964eb to 3e1941a Compare January 6, 2024 17:04
@wojtekmaj wojtekmaj force-pushed the pdfjs-dist-4.0.379 branch 3 times, most recently from 06afe59 to 7d46617 Compare January 17, 2024 20:58
@wojtekmaj wojtekmaj mentioned this pull request Jan 20, 2024
Open
4 tasks
@wojtekmaj
Copy link
Owner Author

wojtekmaj commented Jan 24, 2024 •
edited
Loading

This PR is currently breaking most setups that do not support top level await (including Vite - see code changes in test app in this PR). I consider this a deal breaker at the moment and therefore postpone merging it.

See mozilla/pdf.js#17349 for more details.

@wojtekmaj wojtekmaj mentioned this pull request Jan 24, 2024
Closed
2 tasks
@wojtekmaj wojtekmaj force-pushed the pdfjs-dist-4.0.379 branch 2 times, most recently from 555e3a4 to f030a01 Compare April 30, 2024 10:51
@wojtekmaj wojtekmaj mentioned this pull request Apr 30, 2024
Closed
@wojtekmaj wojtekmaj force-pushed the main branch 6 times, most recently from d5c2c3b to f4d4d49 Compare May 8, 2024 07:20
@wojtekmaj wojtekmaj force-pushed the pdfjs-dist-4.0.379 branch 2 times, most recently from bd703a9 to 34504f8 Compare May 8, 2024 08:07
@wojtekmaj wojtekmaj force-pushed the pdfjs-dist-4.0.379 branch from 34504f8 to bb573ad Compare May 29, 2024 10:47
@wojtekmaj
Copy link
Owner Author

Superseded by #1809

@wojtekmaj wojtekmaj closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of pdfjs-dist v4.0.189
1 participant
@wojtekmaj