-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCP not working when serving through nginx / Cloudflare #107
Comments
Seems to come from: const matches = eTag.match(this.eTagWithSha1HashPattern); |
Hey, do you have your server exposed over some kind of proxy like i.e. nginx? |
Yes, we use meteor up with Nginx and Docker.
Op 10 jun. 2017 10:26 a.m. schreef "Bartosz Wojtkowiak" <
[email protected]>:
… Hey,
do you have your server exposed over some kind of proxy like i.e. nginx?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#107 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL3qWKuF3WR0rRANvRuDNtiKqFg2jxKpks5sClNKgaJpZM4NzFQe>
.
|
`eTag` is a http response header that contains the file hash version, it can be stripped out by a http proxy Relates to #107
Just to clarify further: we're also proxying traffic through Cloudflare. User -> Cloudflare -> Nginx -> Meteor (Docker container) Trying out your fix right now. |
I commented on the commit; should be === instead of !==. When changed it's working fine again! |
`eTag` is a http response header that contains the file hash version, it can be stripped out by a http proxy Relates to #107
Yep, been thinking about one thing and wrote the other ;) v0.7.2 with this fix is released, let me know if this can be closed. |
Working just fine now! |
"[autoupdate] download failure: failed at verifyResponse: Cannot read property 'match' of undefined"
Any pointers?
The text was updated successfully, but these errors were encountered: