Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCP not working when serving through nginx / Cloudflare #107

Closed
KoenLav opened this issue Jun 7, 2017 · 7 comments
Closed

HCP not working when serving through nginx / Cloudflare #107

KoenLav opened this issue Jun 7, 2017 · 7 comments
Assignees
Milestone

Comments

@KoenLav
Copy link
Contributor

KoenLav commented Jun 7, 2017

"[autoupdate] download failure: failed at verifyResponse: Cannot read property 'match' of undefined"

Any pointers?

@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 7, 2017

Seems to come from: const matches = eTag.match(this.eTagWithSha1HashPattern);

@wojtkowiak wojtkowiak self-assigned this Jun 10, 2017
@wojtkowiak
Copy link
Owner

Hey,

do you have your server exposed over some kind of proxy like i.e. nginx?

@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 10, 2017 via email

wojtkowiak added a commit that referenced this issue Jun 10, 2017
`eTag` is a http response header that contains the file hash version,
it can be stripped out by a http proxy

Relates to #107
@wojtkowiak wojtkowiak added this to the 0.7.2 milestone Jun 10, 2017
@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 11, 2017

Just to clarify further: we're also proxying traffic through Cloudflare.

User -> Cloudflare -> Nginx -> Meteor (Docker container)

Trying out your fix right now.

@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 11, 2017

I commented on the commit; should be === instead of !==.

When changed it's working fine again!

@KoenLav KoenLav changed the title HCP not working HCP not working when serving through nginx / Cloudflare Jun 11, 2017
wojtkowiak added a commit that referenced this issue Jun 12, 2017
`eTag` is a http response header that contains the file hash version,
it can be stripped out by a http proxy

Relates to #107
@wojtkowiak
Copy link
Owner

I commented on the commit; should be === instead of !==.

Yep, been thinking about one thing and wrote the other ;)

v0.7.2 with this fix is released, let me know if this can be closed.
And thanks for you time investigating this!

@KoenLav
Copy link
Contributor Author

KoenLav commented Jun 15, 2017

Working just fine now!

@KoenLav KoenLav closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants