wolfMQTT Release v1.14.1 preparation #308
Conversation
| #if !defined(HAVE_CONFIG_H) && !defined(BUILDING_CMAKE) | ||
|
|
||
| /* Don't include this if using autoconf cross-compile */ | ||
| #if !defined(HAVE_CONFIG_H) |
There was a problem hiding this comment.
This BUILDING_CMAKE fixed a vcpkg issue. Do you have a plan for how to fix this in vcpkg with Windows Cmake? I was not able to get the vcpkg update through without it. See microsoft/vcpkg#25936
There was a problem hiding this comment.
Yeah, I'll have to figure something else out. That change definitely breaks vcpkg / VS builds.
There was a problem hiding this comment.
From zd14640
The problem was as I explained earlier; the config used to build the wolfMQTT library in vcpkg was different from the config the application was using. I was able to resolve the issue by removing the section of the diff patch that changes wolfmqtt/vs_settings.h
There was a problem hiding this comment.
That's fine, but you will likely need to find another solution for the vcpkg CI tests with wolfMQTT and Windows.
There was a problem hiding this comment.
And that will likely require a patch to the vcpkg.
|
Just heads up, this merge build needs a rerun. |
Also revert vs_settings.h change in #305