Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dilithium: Final and draft available in one build #8016

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Dilithium: Final and draft available in one build #8016

merged 1 commit into from
Oct 2, 2024

Conversation

SparkiDev
Copy link
Contributor

Description

Make draft version of ML-DSA compiled in with final. Use WC_ML_DSA_44_DRAFT, WC_ML_DSA_65_DRAFT and WC_ML_DSA_87_DRAFT for the level to get the draft implementation.

Fixes zd#18678

Testing

--enable-dilithium
--enable-dilithium=yes,fips204-draft

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Sep 25, 2024
@philljj philljj mentioned this pull request Sep 26, 2024
Merged
@SparkiDev SparkiDev force-pushed the dilithium_draft_final_fix branch 3 times, most recently from 7d0a8d2 to fe15128 Compare September 26, 2024 07:31
@philljj philljj mentioned this pull request Sep 30, 2024
Merged
@SparkiDev SparkiDev force-pushed the dilithium_draft_final_fix branch from fe15128 to c4cdf21 Compare October 2, 2024 11:04
@SparkiDev
Dilithium: Final and draft available in one build
50bbdbb 
Make draft version of ML-DSA compiled in with final.
Use WC_ML_DSA_44_DRAFT, WC_ML_DSA_65_DRAFT and WC_ML_DSA_87_DRAFT for
the level to get the draft implementation.
@SparkiDev SparkiDev force-pushed the dilithium_draft_final_fix branch from c4cdf21 to 50bbdbb Compare October 2, 2024 12:23
@douzzer
Copy link
Contributor

douzzer commented Oct 2, 2024

tested with wolfssl-multi-test.sh ... quantum-safe-wolfssl-all-g++-latest-debug quantum-safe-wolfssl-all-cppcheck quantum-safe-wolfssl-all-gcc-latest quantum-safe-wolfssl-all-g++-latest quantum-safe-all-crypt-sp-math-vector-register-access quantum-safe-wolfssl-all-clang-tidy quantum-safe-wolfssl-all-no-asm-clang-tidy quantum-safe-wolfssl-all-intelasm-sp-asm-sanitizer quantum-safe-wolfssl-all-intelasm-sp-asm-valgrind quantum-safe-wolfssl-all-noasm-valgrind quantum-safe-wolfssl-all-noasm-sanitizer quantum-safe-wolfssl-all-noasm-noinline-sanitizer quantum-safe-wolfssl-all-noasm-smallstack-sanitizer quantum-safe-wolfssl-all-crypto-only-noasm-linuxkm-insmod quantum-safe-wolfssl-all-crypto-only-intelasm-sp-asm-linuxkm-insmod quantum-safe-wolfssl-all-noasm-stack-sizes quantum-safe-wolfssl-all-crypto-only-benchmark-sanitizer quantum-safe-wolfssl-all-cross-aarch64-armasm-unittest-sanitizer quantum-safe-wolfssl-all-cross-armv7a-armasm-unittest quantum-safe-wolfssl-all-fips204-clang-tidy, of which quantum-safe-wolfssl-all-fips204-clang-tidy is new to cover this PR.

@douzzer douzzer merged commit e814d1b into wolfSSL:master Oct 2, 2024
139 checks passed
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Nov 12, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
8d32101 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Nov 14, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
004fe64 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Nov 15, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
0cc2b19 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Nov 18, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
e52a946 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Nov 29, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
157a067 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Dec 13, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
d9149e8 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Dec 17, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
a0b65e4 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Dec 20, 2024
@Frauschi
Fixes for ML-DSA in TLS handshake
f158a16 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Jan 7, 2025
@Frauschi
Fixes for ML-DSA in TLS handshake
ec661c1 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Jan 15, 2025
@Frauschi
Fixes for ML-DSA in TLS handshake
ff4757e 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Jan 24, 2025
@Frauschi
Fixes for ML-DSA in TLS handshake
da98d81 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Jan 28, 2025
@Frauschi
Fixes for ML-DSA in TLS handshake
f11bb73 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Jan 29, 2025
@Frauschi
Fixes for ML-DSA in TLS handshake
e19c291 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Frauschi added a commit to Laboratory-for-Safe-and-Secure-Systems/wolfssl that referenced this pull request Feb 7, 2025
@Frauschi
Fixes for ML-DSA in TLS handshake
8e6f1d9 
After wolfSSL#8016 enabled support for both the final and the draft versions of
ML-DSA simultaneously, the commit adds necessary changes to properly use
both in the TLS handshake for authentication.

Signed-off-by: Tobias Frauenschläger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douzzer douzzer douzzer approved these changes

Assignees

@SparkiDev SparkiDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SparkiDev @douzzer