20241002-fix-for-cppcheck-force-source #8039
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douzzer
force-pushed
the
20241002-fix-for-cppcheck-force-source
branch
from
7f31cc8 to
2d7979e
Compare
…or some gating/conditionalization around ATOMIC_USER, HAVE_ENCRYPT_THEN_MAC, atomicUser, and ssl->options.startedETMRead, to avoid "Logical disjunction always evaluates to true" from cppcheck incorrectLogicOperator (via multi-test cppcheck-force-source) (warned code introduced by 99a99e3).
douzzer
force-pushed
the
20241002-fix-for-cppcheck-force-source
branch
from
2d7979e to
b81cc50
Compare
|
retest this please |
SparkiDev
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/internal.c: inProcessReplyEx()in theverifyMessagecase, refactor some gating/conditionalization aroundATOMIC_USER,HAVE_ENCRYPT_THEN_MAC,atomicUser, andssl->options.startedETMRead, to avoid "Logical disjunction always evaluates to true" fromcppcheckincorrectLogicOperator(via multi-testcppcheck-force-source) (warned code introduced by 99a99e3).tested with
wolfssl-multi-test.sh ... super-quick-check cppcheck-force-source