20250103-Sha512Final-no-scratch-digest #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
requested changes
Jan 5, 2025
…refactor out the scratch digest -- ByteReverseWords64() is safe in-place, and the scratch digest caused a SEGV in the XMEMCPY() on AVX512-capable targets built with gcc -march=native unless XALIGN(64), due to gcc bug(s).
douzzer
force-pushed
the
20250103-Sha512Final-no-scratch-digest
branch
from
810a46c to
5172ff7
Compare
|
retest this please (timeouts on |
SparkiDev
approved these changes
Jan 6, 2025
|
retest this please (Windows worker node glitch now fixed) |
dgarske
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/sha512.c: inSha512FinalRaw()andwc_Sha384FinalRaw(), refactor out the scratch digest --ByteReverseWords64()is safe in-place, and the scratch digest caused aSEGVin theXMEMCPY()on AVX512-capable targets built withgcc -march=native -O2unlessXALIGN(64), due togccbug(s).Note, the bug only manifests in ASAN builds, repro'd on gcc-13, gcc-14, and gcc-15. Regular
-O2build passesunit.testwithout this patch.tested with
wolfssl-multi-test.sh check-source-text sp-all-asm-sanitizeron an AVX512 target.