20250107-clang-tidy-xmss

[douzzer]

wolfcrypt/src/wc_xmss_impl.c: guided by clang-tidy 20.0.0_pre20250104, add some error-checking to wc_xmss_bds_state_load() and wc_xmss_bds_state_store(), but ultimately, suppress a pair of stubborn apparently-false "function call argument is an uninitialized value" warnings, one in wc_xmss_bds_state_store() and one in wc_xmss_sign().

/tmp/tmp.4346_11739/wolfssl_test_workdir.2704/wolfssl/wolfcrypt/src/wc_xmss_impl.c:2758:9: warning: 1st function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
2758 |         c32to24(bds[i].next, sk);
|         ^

/tmp/tmp.4346_11739/wolfssl_test_workdir.2704/wolfssl/wolfcrypt/src/wc_xmss_impl.c:3483:9: warning: 2nd function call argument is an uninitialized value [clang-analyzer-core.CallAndMessage]
3483 |         XMEMCPY(sig, bds->authPath, h * n);
|         ^

tested with wolfssl-multi-test.sh ... super-quick-check

[douzzer]

[all-c89-clang-tidy] [36 of 324] [8c32238733]
    configure...   real 0m14.072s  user 0m8.649s  sys 0m6.189s
    build...
/tmp/wolfbot_37789/wolfssl_test_workdir.17906/wolfssl/wolfcrypt/src/pkcs7.c:1580:21: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign]
1580 |         ea[i].value = attribs[i].value;
|                     ^

[douzzer]

/tmp/wolfbot_37789/wolfssl_test_workdir.8822/wolfssl/wolfcrypt/src/integer.c:1765:15: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
1765 |       *tmpc = *tmpa++ + *tmpb++ + u;
|               ^

/tmp/wolfbot_37789/wolfssl_test_workdir.8822/wolfssl/wolfcrypt/src/integer.c:1780:17: warning: Dereference of null pointer (loaded from variable 'tmpc') [clang-analyzer-core.NullDereference]
1780 |           *tmpc = x->dp[i] + u;
|                 ^

/tmp/wolfbot_37789/wolfssl_test_workdir.8822/wolfssl/wolfcrypt/src/integer.c:1780:19: warning: Array access (via field 'dp') results in a null pointer dereference [clang-analyzer-core.NullDereference]
1780 |           *tmpc = x->dp[i] + u;
|                   ^

/tmp/wolfbot_37789/wolfssl_test_workdir.8822/wolfssl/wolfcrypt/src/integer.c:1791:13: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
1791 |     *tmpc++ = u;
|             ^

/tmp/wolfbot_37789/wolfssl_test_workdir.8822/wolfssl/wolfcrypt/src/integer.c:2949:14: warning: Array access (via field 'dp') results in a null pointer dereference [clang-analyzer-core.NullDereference]
2949 |     a->dp[i] |= ((mp_digit)1) << (b % DIGIT_BIT);
|              ^

/tmp/wolfbot_37789/wolfssl_test_workdir.8822/wolfssl/wolfcrypt/src/integer.c:3008:11: warning: Dereference of null pointer [clang-analyzer-core.NullDereference]
3008 |   *tmpc++ = u;
|           ^

Fixed