Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python update to 3.12.6 #8345

Merged
merged 28 commits into from
Jan 24, 2025
Merged

Python update to 3.12.6 #8345

merged 28 commits into from
Jan 24, 2025

Conversation

JacobBarthelmeh
Copy link
Contributor

ZD18885

@JacobBarthelmeh JacobBarthelmeh self-assigned this Jan 9, 2025
@JacobBarthelmeh JacobBarthelmeh force-pushed the python_update branch 2 times, most recently from ac09b58 to bdc1b19 Compare January 9, 2025 17:28
@JacobBarthelmeh
Copy link
Contributor Author

Failing test case for Python 3.8.14 port needs these changes wolfSSL/osp#225

@JacobBarthelmeh
Copy link
Contributor Author

JacobBarthelmeh commented Jan 21, 2025 •
edited
Loading

Retest this please Jenkins

@dgarske dgarske self-requested a review January 21, 2025 23:04
dgarske
dgarske requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split out the codespell stuff to give more time to review.

src/ssl_load.c:2818                 wolfSSL_X509_STORE_add_crl(wolfSSL_CTX_get_cert_store(ctx), &crl);```

wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
dgarske
dgarske previously approved these changes Jan 22, 2025
View reviewed changes
@JacobBarthelmeh JacobBarthelmeh removed their assignment Jan 22, 2025
@JacobBarthelmeh
Copy link
Contributor Author

@dgarske I don't understand the only failing test here with codespell. A grep for sytem in wolfssl/ssl.h turned up no hits.

@dgarske
Copy link
Contributor

dgarske commented Jan 22, 2025

Okay to merge with code spell issue. I've asked @julek-wolfssl to review this today quickly. Let's get this merged soon.

@dgarske dgarske requested a review from julek-wolfssl January 22, 2025 16:46
julek-wolfssl
julek-wolfssl requested changes Jan 22, 2025
View reviewed changes
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review so far. Still need to look at src and tests.

wolfssl/internal.h Outdated Show resolved Hide resolved
wolfssl/internal.h Show resolved Hide resolved
wolfcrypt/src/evp.c Show resolved Hide resolved
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
julek-wolfssl
julek-wolfssl reviewed Jan 22, 2025
View reviewed changes
src/internal.c Outdated Show resolved Hide resolved
src/internal.c Outdated Show resolved Hide resolved
src/internal.c Outdated Show resolved Hide resolved
src/internal.c Outdated Show resolved Hide resolved
src/ssl_load.c Outdated Show resolved Hide resolved
src/ssl.c Outdated Show resolved Hide resolved
wolfssl/internal.h Show resolved Hide resolved
julek-wolfssl
julek-wolfssl requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Missing tests for wolfSSL_write_ex and wolfSSL_read_ex.

src/ssl.c Outdated Show resolved Hide resolved
src/ssl.c Outdated Show resolved Hide resolved
src/ssl.c Show resolved Hide resolved
src/tls13.c Outdated Show resolved Hide resolved
src/x509.c Outdated Show resolved Hide resolved
tests/api.c Outdated Show resolved Hide resolved
tests/api.c Outdated Show resolved Hide resolved
tests/api.c Outdated Show resolved Hide resolved
@JacobBarthelmeh
fix for smallstack build
418e63e
@JacobBarthelmeh
add some unit test cases
49c515a
@JacobBarthelmeh
fix for memory leak with new wolfSSL_get_client_ciphers function
2812baf
@JacobBarthelmeh
fix for macro guard on free of clSuites
661f6b0
@JacobBarthelmeh
fix for macro guard with QT build
da7543f
@JacobBarthelmeh
cast data input to const and resolve overlong line length
fc563f2
@JacobBarthelmeh
increase test coverage
286b9b6
@JacobBarthelmeh
adjust behavior when calling non XOF digest final function with XOF d…
2eb42f1 
…igest type
@JacobBarthelmeh
change return of stub functions to be failure, pass PEM password cb a…
86ed94f 
…nd user data along
@JacobBarthelmeh
refactor clSuites internal use, and check return values with setting …
8ca979f 
…PARAMS
@JacobBarthelmeh
remove attempting to load a CRL with wolfSSL_CTX_load_verify_location…
1e3d3dd 
…s_ex
@JacobBarthelmeh
handle edge case with wolfSSL_write_ex and refactor wolfSSL_get_clien…
41e00dc 
…t_ciphers
@JacobBarthelmeh
account for correct return value of cipher stack push and clSuite use…
9b04a4f 
… case after rebase
@julek-wolfssl julek-wolfssl self-requested a review January 24, 2025 17:53
julek-wolfssl
julek-wolfssl requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Just a few remaining comments.

wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
src/internal.c Outdated Show resolved Hide resolved
src/ssl_load.c Show resolved Hide resolved
@dgarske dgarske self-requested a review January 24, 2025 18:53
@dgarske dgarske merged commit 2e87dfc into wolfSSL:master Jan 24, 2025
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julek-wolfssl julek-wolfssl julek-wolfssl approved these changes

@dgarske dgarske dgarske approved these changes

Assignees

@JacobBarthelmeh JacobBarthelmeh

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobBarthelmeh @dgarske @julek-wolfssl @wolfSSL-Bot