ML-KEM/Kyber: small memory usage #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
mlkem_kyber_small_mem
branch
3 times, most recently
from
208dd09 to
95c92cc
Compare
|
retest this please |
Options to compile ML-KEM/Kyber to use less dynamic memory. Only available with C code and has small performance trade-off.
SparkiDev
force-pushed
the
mlkem_kyber_small_mem
branch
from
95c92cc to
316177a
Compare
dgarske
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
All tests out and works great. The memory numbers I see are heap reduce from 17576 to 7848.
./configure --enable-all --enable-experimental --enable-dilithium --enable-kyber CFLAGS="-DWOLFSSL_MLKEM_ENCAPSULATE_SMALL_MEM -DWOLFSSL_MLKEM_MAKEKEY_SMALL_MEM" --enable-trackmemory=verbose --enable-stacksize=verbose --disable-asm && make
Before:
KYBER test passed!
relative stack peak usage = 36872 bytes
relative heap peak usage: 3 allocs, 17576 bytes
After (with small):
KYBER test passed!
relative stack peak usage = 36936 bytes
relative heap peak usage: 3 allocs, 7848 bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Options to compile ML-KEM/Kyber to use less dynamic memory.
Only available with C code and has small performance trade-off.
Testing
Regression tested ML-KEM/Kyber.
Checklist