Fix potential memory leak on error in LoadCRL() #8415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ProcessFile() fails, the code does not clean up readCtx. Perform the same cleanup as after the loop to fix this.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If ProcessFile() fails, the code does not clean up readCtx. Perform the same cleanup as after the loop to fix this.
Note: this was found by an experimental static analyser I'm developing, so it's possible that I'm missing some details as I'm not very familiar with the code.
Testing
It appears that this if condition is not hit when running
make test, unless I miss something. So I didn't know how to test this.Checklist